Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/em100/+/35066 )
Change subject: firmware.c: Check pointer returned by malloc ......................................................................
firmware.c: Check pointer returned by malloc
Change-Id: Iecf92a9acc54a4ab0a94867e5db265e1db943d53 Signed-off-by: Patrick Georgi pgeorgi@google.com Found-by: Coverity Scan #220610 Reviewed-on: https://review.coreboot.org/c/em100/+/35066 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jacob Garber jgarber1@ualberta.ca Reviewed-by: Angel Pons th3fanbus@gmail.com --- M firmware.c 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Jacob Garber: Looks good to me, approved
diff --git a/firmware.c b/firmware.c index b3abafe..f5716d8 100644 --- a/firmware.c +++ b/firmware.c @@ -191,6 +191,11 @@ fseek(f, 0, SEEK_SET);
fw = malloc(fsize); + if (!fw) { + printf("ERROR: out of memory.\n"); + fclose(f); + return 0; + } if (fread(fw, fsize, 1, f) != 1) { perror(filename); fclose(f);