Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36657 )
Change subject: lib/fmap: Add optional pre-RAM cache
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36657/1/src/lib/cbfs.c
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/36657/1/src/lib/cbfs.c@301
PS1, Line 301: /* Find location of header using signed 32-bit offset from
Does anyone know why we're still doing all this crap at all? Can I just take the offset and size from the FMAP directly instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36657
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2820436776ef620bdc4481b5cd4b6957764248ea
Gerrit-Change-Number: 36657
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 Nov 2019 03:43:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment