build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34332 )
Change subject: mediatek/mt8183: support DDR frequency 3600Mbps ......................................................................
Patch Set 2:
(21 comments)
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1728: dqsDelay = s_dqsDelay[dqs] ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1893: dramc_dbg("%s CH%u RK%u, freq:%d\n", __func__, chn, rank, freqTbl[freq_group]); line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1937: if (operate_fsp == FSP_0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1937: if (operate_fsp == FSP_0) suspect code indent for conditional statements (24, 28)
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1941: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1941: else suspect code indent for conditional statements (24, 28)
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1941: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1969: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 2022: { that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 2118: .r_dmmrw_intv = 0xf, //Berson: LP3/4 both use this field -> Formula may change, set to 0xF for now line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 2131: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 2239: (twtr_05T << 25) | (trtw_ODT_on_05T << 24) | (twtpd_05T << 16) | (trtpd_05T << 15) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 2240: (tfaw_05T << 13) | (trrd_05T << 12) | (twr_05T << 10) | (tras_05T << 9) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 152: (0x7 << 4) |(0x1 << 7) |(0x3 << 0), need consistent spacing around '|' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 152: (0x7 << 4) |(0x1 << 7) |(0x3 << 0), need consistent spacing around '|' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1269: virtual_delay = (((((tx_dly >> (dqs << 2)) & 0x7) << mck) + ((dly >> (dqs << 2)) & 0x7)) << 5) + line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1391: dramc_dbg(" %s win_size_sum:%d, max_win:%d, vref_dly->min_win :%d, min_win_size_vref:%d \n", unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1392: __func__, win_size_sum, vref_dly->max_win, vref_dly->min_win, min_win_size_vref); line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/dra... PS2, Line 1796: dq_perbit_dly[bit].dqdly.best_last - dq_perbit_dly[bit].dqdly.best_first, line over 96 characters
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/emi... PS2, Line 274: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/34332/2/src/soc/mediatek/mt8183/emi... PS2, Line 283: { that open brace { should be on the previous line