Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40337 )
Change subject: soc/intel/{apl, cnl, skl}: Add sanity check of SA_PCIEX_LENGTH_MIB
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40337/4/src/soc/intel/apollolake/sy...
File src/soc/intel/apollolake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/40337/4/src/soc/intel/apollolake/sy...
PS4, Line 25:
: #if (CONFIG_SA_PCIEX_LENGTH_MIB > 0x100) /* Max length is 256MB */
: #error "Invalid SA_PCIEX_LENGTH_MIB selection!"
: #endif
May be we can put this check in soc/systemagent.h ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40337
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dd67868df373c6ab5c724a21371bcc206968036
Gerrit-Change-Number: 40337
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 20 Apr 2020 22:06:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment