Wolfgang Kamp has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40694 )
Change subject: soc/intel/apl: Add panel power and backlight configuration
......................................................................
Patch Set 4:
I have tested the patch with real hardware on Apollo Lake SMARC modul with baseboard and LVDS TFT display. I used the following devicetree entries:
# IGD Displays
register "gpu_pp[0].up_delay_ms" = "100"
register "gpu_pp[0].down_delay_ms" = "500"
register "gpu_pp[0].cycle_delay_ms" = "500"
register "gpu_pp[0].backlight_on_delay_ms" = " 1"
register "gpu_pp[0].backlight_off_delay_ms" = "200"
register "gpu_blc[0].pwm_hz" = "192"
register "gpu_blc[0].polarity" = "GPU_BACKLIGHT_POLARITY_HIGH"
Software configuration: coreboot using libgfxinit and UEFI payload.
It works fine! No problems encountered.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40694
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8892ac7aafce1006831e2d9f2806919f5950756
Gerrit-Change-Number: 40694
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wolfgang Kamp
wmkamp@datakamp.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Sep 2020 11:47:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment