[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/nissa/var/glassway: Set VccIn Aux Imon IccMax to 25 A

[Frank Chu (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik.

Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81445?usp=email )

Change subject: mb/google/nissa/var/glassway: Set VccIn Aux Imon IccMax to 25 A
......................................................................

Patch Set 8: Code-Review+1

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81445/comment/1aad9879_652987cb :
PS6, Line 7: Update the VccIn Aux Imon IccMax
> Set VccIn Aux Imon IccMax to 25 A

Done

https://review.coreboot.org/c/coreboot/+/81445/comment/1cb14407_f63c2fc4 :
PS6, Line 9: Iccmax of VccIn_Aux is 25A with MBVR design.
> What is the current default?

Intel FSP ADL default 27A

https://review.coreboot.org/c/coreboot/+/81445/comment/dd669f57_778f7c96 :
PS6, Line 9: MBVR
> What does that mean?

For FIVR design, the VccInAuxImonIccImax should be 27A, for MBVR design VccInAuxImonIccImax should be 25A.

File src/mainboard/google/brya/variants/glassway/ramstage.c:

https://review.coreboot.org/c/coreboot/+/81445/comment/42bb8cd2_4b049af1 :
PS6, Line 10:
> Remove blank line, if possible (or Gerrit bug).

build bot error: adding a line without newline at end of file