Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35237 )
Change subject: soc/intel/{cnl, icl}: Allocate 64KB as FSP heap ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35237/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35237/1//COMMIT_MSG@7 PS1, Line 7: 64KB as FSP heap
How was this size determined?
it will be captured in next FSP integration guide release. and FSP team will update the requirement from now onwards
https://review.coreboot.org/c/coreboot/+/35237/1/src/soc/intel/cannonlake/Kc... File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/35237/1/src/soc/intel/cannonlake/Kc... PS1, Line 122: default 0x20000 if FSP_USES_CB_STACK
If 64KB was used for the HOB heap, then shouldn't this be 0x10000 now? Or should we change this to […]
No Aaron/Tim. Stack requirement remain same ~128KB and HOB heap requirement is ~64KB. earlier we were actually passing ~128KB to stack and heap both using same arch->upd = stack_size. Now with next integration guide things will be call out correctly.
https://review.coreboot.org/c/coreboot/+/35237/1/src/soc/intel/cannonlake/Kc... PS1, Line 131: 0x10000
64KB worth of HOBs?
integration guide will call that out, its combination of HOB and some other features. As i understood from CML FSP document will specify the same size