Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42302 )
Change subject: mb/google/volteer/var/terrador: Update gpio settings and overridetree.cb ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42302/10/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/terrador/gpio.c:
https://review.coreboot.org/c/coreboot/+/42302/10/src/mainboard/google/volte... PS10, Line 100: /* E12 : SPI1_MISO_IO1 ==> PEN_ALERT_ODL */ : PAD_CFG_GPI(GPP_E12, NONE, DEEP), : Because you are overriding one of the GPIOs in the baseboard's early_gpio_table[] array, you need to define a seperate early_gpio_table[] for terrodor in this file.
To do so, you can copy the early_gpio_table structure from mainboard/google/volteer/variant/baseboard/gpio.c and paste it into this file, and then change the GPP_E12 entry in that early_gpio_table that you just copied to this file to match what you've defined here for GPP_E12.
You will also need to add the following routine to this file :
const struct pad_config *variant_early_gpio_table(size_t *num) { *num = ARRAY_SIZE(early_gpio_table); return early_gpio_table; }