Ran Bi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32339 )
Change subject: mediatek/mt8183: Enable RTC eosc calibration feature to save power ......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG@9 PS1, Line 9: shutdown
Does BT mean Bluetooth? What does the PMIC RTC clock have to do with Bluetooth? And are we actually using the PMIC watchdog for anything? (I assume this is different from the AP watchdog?) We generally only want one hardware watchdog on the system, otherwise they'll just get in each other's way.
Yes, BT means Bluetooth. BT using 32K clock source which RTC output. AP watchdog/SPM also using 32K clock source which RTC output.
Do you not have an RTC/PMIC driver in the kernel. Also, what RTC alarm stuff do you have in TF? That really sounds like something that should only be in the kernel.
ATF PSCI system_off function is the last step of system shutdown. We need to do some PMIC and RTC settings here then trigger PMIC register to disable power supply to SoC.