Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46018 )
Change subject: soc/intel/*: conversion from constant to Kconfig for XTAL frequency ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46018/3/src/soc/intel/alderlake/Kco... File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/46018/3/src/soc/intel/alderlake/Kco... PS3, Line 137: int No need to repeat the type everywhere. Just declare it once where it's used.
https://review.coreboot.org/c/coreboot/+/46018/3/src/soc/intel/alderlake/cpu... File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/46018/3/src/soc/intel/alderlake/cpu... PS3, Line 118: CONFIG_SOC_INTEL_COMMON_BLOCK_XTAL_CLOCK_HZ There is no benefit in using the full macro name here. You could just say `clock`.