Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39801 )
Change subject: [WIP]TGL: Make the GPIO asl table in sync with kernel
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39801/2/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39801/2/src/soc/intel/tigerlake/acp...
PS2, Line 20: #if CONFIG(SOC_INTEL_TIGERLAKE)
There are some changes happening for JSL GPIO as well here: CB:39470
I think we should probably just split TGL and JSL SoCs(CB:39774) first and then take this change in. Adding Karthik and Aamir.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f1d399ff7380125ad5b935f9590a7d9cc442b04
Gerrit-Change-Number: 39801
Gerrit-PatchSet: 2
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Mar 2020 20:21:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment