[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC contr...

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30614 )

Change subject: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC controller
......................................................................

Patch Set 3:

(4 comments)

https://review.coreboot.org/#/c/30614/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30614/3//COMMIT_MSG@7 
PS3, Line 7: Adding
Please use imperative mood: Add

https://review.coreboot.org/#/c/30614/3//COMMIT_MSG@9 
PS3, Line 9: an Kconfig
a Kconfig

https://review.coreboot.org/#/c/30614/3//COMMIT_MSG@11 
PS3, Line 11: 
… as there are platforms – like … – that do not have an eMMC slot(?).

https://review.coreboot.org/#/c/30614/3/src/soc/intel/cannonlake/Kconfig 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/#/c/30614/3/src/soc/intel/cannonlake/Kconfig@194 
PS3, Line 194: config EXCLUDE_EMMC_INTERFACE
This should be name-spaced by prepending SOC_INTEL_.