Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41900 )
Change subject: drivers/usb/pci_xhci: Add a driver to generate xHCI ACPI nodes ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41900/5/src/drivers/usb/pci_xhci/ch... File src/drivers/usb/pci_xhci/chip.h:
https://review.coreboot.org/c/coreboot/+/41900/5/src/drivers/usb/pci_xhci/ch... PS5, Line 11: __XHCI_ACPI_CHIP_H__
__USB_XHCI_PCI_CHIP_H__
Done
https://review.coreboot.org/c/coreboot/+/41900/4/src/drivers/usb/pci_xhci/pc... File src/drivers/usb/pci_xhci/pci_xhci.c:
https://review.coreboot.org/c/coreboot/+/41900/4/src/drivers/usb/pci_xhci/pc... PS4, Line 1: GPL-2.0-only
Should I be using GPL-2. […]
Ack
https://review.coreboot.org/c/coreboot/+/41900/5/src/drivers/usb/pci_xhci/pc... File src/drivers/usb/pci_xhci/pci_xhci.c:
https://review.coreboot.org/c/coreboot/+/41900/5/src/drivers/usb/pci_xhci/pc... PS5, Line 167:
I was thinking some more about this. […]
Done
https://review.coreboot.org/c/coreboot/+/41900/6/src/drivers/usb/pci_xhci/pc... File src/drivers/usb/pci_xhci/pci_xhci.c:
https://review.coreboot.org/c/coreboot/+/41900/6/src/drivers/usb/pci_xhci/pc... PS6, Line 167:
I didn't want to maintain another list of PCI_IDs. […]
Done