[coreboot-gerrit] Change in coreboot[master]: [TEST]mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC To d...

[John Su (Code Review)]

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49683 )

Change subject: [TEST]mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC To define Mainboard Type config, use the fw_config bit[26]. Check MB Type to modify SDLE settings for different VCORE IC.
......................................................................

[TEST]mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC
To define Mainboard Type config, use the fw_config bit[26].
Check MB Type to modify SDLE settings for different VCORE IC.

BUG=b:177193131
BRANCH=zork

Signed-off-by: John Su 
Change-Id: If153c0a3e641ae32ef89737925bd9f62dfb71f3d
---
M src/mainboard/google/zork/variants/baseboard/helpers.c
M src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/zork/variants/vilboz/variant.c
3 files changed, 17 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/49683/1

diff --git a/src/mainboard/google/zork/variants/baseboard/helpers.c b/src/mainboard/google/zork/variants/baseboard/helpers.c
index 00e7a03..38f0a72 100644
--- a/src/mainboard/google/zork/variants/baseboard/helpers.c
+++ b/src/mainboard/google/zork/variants/baseboard/helpers.c
@@ -43,6 +43,9 @@
    /* SAR presence */
    FW_CONFIG_MASK_SAR = 0x7,
    FW_CONFIG_SHIFT_SAR = 23,
+	/* Mainboard Type for VCORE IC */
+	FW_CONFIG_MASK_MB_TYPE = 0x1,
+	FW_CONFIG_SHIFT_MB_TYPE = 26,
    /* Fan information */
    FW_CONFIG_MASK_FAN = 0x3,
    FW_CONFIG_SHIFT_FAN = 27,
@@ -86,6 +89,11 @@
    return extract_field(FW_CONFIG_MASK_SAR, FW_CONFIG_SHIFT_SAR);
 }

+int variant_gets_mb_type_config(void)
+{
+	return extract_field(FW_CONFIG_MASK_MB_TYPE, FW_CONFIG_SHIFT_MB_TYPE);
+}
+
 int variant_has_emmc(void)
 {
    return !!extract_field(FW_CONFIG_MASK_EMMC, FW_CONFIG_SHIFT_EMMC);
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h
index ac600de..c09ace0 100644
--- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h
@@ -61,6 +61,8 @@
 /* Retrieve attributes from FW_CONFIG in CBI. */
 /* Return value of SAR config. */
 int variant_gets_sar_config(void);
+/* Return value of Mainboard Type config */
+int variant_gets_mb_type_config(void);
 /* Return 0 if non-existent, 1 if present. */
 int variant_has_emmc(void);
 /* Return 0 if non-existent, 1 if present. */
diff --git a/src/mainboard/google/zork/variants/vilboz/variant.c b/src/mainboard/google/zork/variants/vilboz/variant.c
index 3816aac..d793131 100644
--- a/src/mainboard/google/zork/variants/vilboz/variant.c
+++ b/src/mainboard/google/zork/variants/vilboz/variant.c
@@ -42,6 +42,13 @@
    /* b:/174121847 Use external OSC to mitigate noise for WWAN sku. */
    if (variant_has_wwan())
    	soc_cfg->acp_i2s_use_external_48mhz_osc = 1;
+
+	if (variant_gets_mb_type_config()) {
+		soc_cfg->telemetry_vddcr_vdd_slope_mA = 32453;
+		soc_cfg->telemetry_vddcr_vdd_offset = 168;
+		soc_cfg->telemetry_vddcr_soc_slope_mA = 22644;
+		soc_cfg->telemetry_vddcr_soc_offset = -70;
+	}
 }

/*