build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )
Change subject: soc/intel/common/block: Enable PMC IPC driver in coreboot ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37871/3/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/37871/3/src/soc/intel/common/block/... PS3, Line 239: int pmc_send_ipc_cmd (uint32_t cmd, uint32_t sub, uint8_t *in, uint32_t inlen, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/37871/3/src/soc/intel/common/block/... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/37871/3/src/soc/intel/common/block/... PS3, Line 628: int pmc_send_ipc_cmd (uint32_t cmd, uint32_t sub, uint8_t *in, uint32_t inlen, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/37871/3/src/soc/intel/common/block/... PS3, Line 650: if(check_ips_sts(pmcbase)) { space required before the open parenthesis '('