22 Sep
2021
22 Sep
'21
11:20 a.m.
Attention is currently required from: Reka Norman, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57795 )
Change subject: lib/Makefile.inc: Generate placeholder spd.bin in lib/Makefile.inc ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
It seems to have worked. Jenkins is passing on the dedede and guybrush migration changes now.
`==` is specific to bash. Using `=` instead makes sense as that conforms to POSIX sh standard.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57795
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11f8f9b7ea3bc32aa5c7a617558572a5c1c74c72
Gerrit-Change-Number: 57795
Gerrit-PatchSet: 3
Gerrit-Owner: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Reka Norman rekanorman@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Wed, 22 Sep 2021 18:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman rekanorman@chromium.org
Gerrit-MessageType: comment