[coreboot-gerrit] [S] Change in coreboot[main]: src/cpu/intel/car/romstage: Refactor stack guard code in romstage

[Jérémy Compostella (Code Review)]

Attention is currently required from: Intel coreboot Reviewers, Name of user not set #1005756, Patrick Rudolph.

Jérémy Compostella has posted comments on this change by Name of user not set #1005756. ( https://review.coreboot.org/c/coreboot/+/86562?usp=email )

Change subject: src/cpu/intel/car/romstage: Refactor stack guard code in romstage
......................................................................

Patch Set 3:

(3 comments)

File src/cpu/intel/car/romstage.c:

https://review.coreboot.org/c/coreboot/+/86562/comment/cd75cffc_5e46b662?usp... :
PS3, Line 48: 	int i;
Shouldn't we use `size_t` for an iteration index variable ?

https://review.coreboot.org/c/coreboot/+/86562/comment/772a5b32_b672bdb7?usp... :
PS3, Line 50: 	if (stack_base == NULL) {
How can `stack_base` be `NULL` ?

https://review.coreboot.org/c/coreboot/+/86562/comment/b12aa9c9_1cc2aee3?usp... :
PS3, Line 58: 		printk(BIOS_DEBUG, "Smashed stack detected in romstage!\n");
Is there a reason to keep executing the loop when an issue has been detected ?