Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34282 )
Change subject: Revert "soc/intel/cannonlake: Add option to select FSP_CAR" ......................................................................
Patch Set 2:
Patch Set 2:
Yeah, can't make everybody happy. If I say Google, that's bad, if I say Martin, that's too personal, I get it.
It's not too personal to use are names at all. I felt that the last time we butted heads it was a personal attack that is at least partially due to my employer. I feel like there's an attitude with some that GOOGLE==BAD and anyone who works for them is bad. That's seems to be what you're saying in your commit message here too, so it doesn't seem like I was wrong.
Are you trying to tell me that Aaron's employment has nothing to do with the fact that he didn't ask questions about the `if MAINBOARD_HAS_CHROMEOS` in the patch?!?
Honestly, I don't have any idea what Aaron's thinking, I'm not trying to speak for him, just point out that it was an individual, not "Google". Subrata explained his rationale in his commit message. You may disagree with his thinking, but that's a difference of opinion. Maybe Aaron agreed with him.
If you disagree with the defaults, let's discuss it, but I don't think this revert is appropriate. The commit message and the threats against Subrata are also inappropriate.
Martin, seriously, what the fuck? Subrata is violating our Gerrit guidelines all day and when I complain about it, then that is inappropriate?
If you feel that Subrata is violating guidelines, then bring that up as an issue with examples instead of attacking him and being rude. It seems to me that you're violating guidelines here too - "Be respectful to others when commenting."
If you disagree with the defaults, let's discuss it
I tried to btw. Guess what: Subrata jumped in and gave an immediate -2 based on a hunch that wasn't true at all (that happens regularly btw. sometimes with sometimes without -2). We had a discussion with different folks at Intel based on that hunch. Funny, nobody noticed that it was all void.
Can you give a pointer to that discussion? Let's discuss it in the leadership meeting.
Martin, please see our Gerrit guidelines here: https://doc.coreboot.org/getting_started/gerrit_guidelines.html
Thanks for the pointer Nico, I'm aware of what the guidelines say. I did write them: http://review.coreboot.org/12256
Please give concrete recommendations what I'm supposed to change.
When I said "If you disagree with the defaults, let's discuss it", that's what I was trying to do. Instead of reverting the commit, let's look at changing the defaults.
-----
Look, I'm not opposed to making the open-source CAR the default solution, and I'm not arguing against that. I'm apposed to the tone of your message and the heavy-handed way you're trying to change things.
I know you're trying to do what you think is technically the best for the project, and I can appreciate that. Subrata's doing the same, but he has to work within his constraints. Let's work together to make the project the best we can.
Unless I'm misunderstanding something, Subrata's patch that you're trying to remove here didn't remove any functionality, it just provided an alternative. I get that you disagree with that alternative, but you don't have to use it, and other people might see some advantage to it.
There are different ways of looking at this. Some people see it as corrupting the open-source project. I see it as bringing users to an open source project that might otherwise go with a fully-proprietary firmware. My hope is that we can convince vendors to open-source their currently proprietary binaries, but attacking the vendors and pushing them away from the project certainly won't help with that.