[coreboot-gerrit] Change in coreboot[master]: mb/intel/coffeelake_rvp: Fix display issues on CFL-H, CFL-S, WHL Inte...

[Lean Sheng Tan (Code Review)]

Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34159 )

Change subject: mb/intel/coffeelake_rvp: Fix display issues on CFL-H, CFL-S, WHL Intel RVP
......................................................................

Patch Set 4:

(2 comments)
> Patch Set 4:
>
> (1 comment)

https://review.coreboot.org/c/coreboot/+/34159/4/src/mainboard/intel/coffeel... 
File src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/34159/4/src/mainboard/intel/coffeel... 
PS4, Line 596: SOC_INTEL_CANNONLAKE_PCH_H
> Issue only happened on CNL-H but not CNL-LP? But the changes in devicetree. […]

No it is not generic, CNL-H and CNL-LP have some different sets of GPIO configs

https://review.coreboot.org/c/coreboot/+/34159/4/src/mainboard/intel/coffeel... 
PS4, Line 596: 	#if CONFIG(SOC_INTEL_CANNONLAKE_PCH_H)
> remove tab

Done