Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35742 )
Change subject: mb/facebook/fbg1701: Remove ONBOARD_MICRON_MEM
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35742/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35742/3//COMMIT_MSG@9
PS3, Line 9: Config ONBOARD_MICRON_MEM and ONBOARD_SAMSUNG_MEM are available.
: These configs are used to determine if Samsung or Micron onboard memory is
: assembled. This can not detected run-time.
:
: One CONFIG value will be enough to determine if Samsung memory is
: assembled.
: Only oldest HW revision contains Samsung module, so set
: CONFIG_ONBOARD_SAMSUNG memory to default No.
If I run it through Vim, the text looks like below. […]
Can you clarify the issue?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35742
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id65e92bd4b8d4fe3a6b87dec9bf77e3a62e1be96
Gerrit-Change-Number: 35742
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Oct 2019 13:32:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment