[coreboot-gerrit] [S] Change in coreboot[main]: amdfwtool: Move ISH before PSP L2

[Maximilian Brune (Code Review)]

Attention is currently required from: Bao Zheng, Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, ritul guru.

Maximilian Brune has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84533?usp=email )

Change subject: amdfwtool: Move ISH before PSP L2
......................................................................

Patch Set 12:

(1 comment)

File util/amdfwtool/amdfwtool.c:

https://review.coreboot.org/c/coreboot/+/84533/comment/26add1c1_f04cdad7?usp... :
PS12, Line 972: if (!cb_config->combo_new_rab || ctx->combo_index == 0) {
              : 			pspdir = new_psp_dir(ctx, cb_config->multi_level, cookie);
              : 			ctx->pspdir = pspdir;
              : 			if (recovery_ab)
              : 				ctx->pspdir_bak = new_psp_dir(ctx, cb_config->multi_level, cookie);
              : 		}
              : 		/* The ISH tables are with PSP L1. */
              : 		if (cb_config->need_ish && ctx->ish_a_dir == NULL)	/* Need ISH */
              : 			ctx->ish_a_dir = new_ish_dir(ctx);
              : 		if (cb_config->need_ish && ctx->ish_b_dir == NULL)	/* Need ISH */
              : 			ctx->ish_b_dir = new_ish_dir(ctx);
What happens if `combo_new_rab = 0` and `recovery_ab = 1` ? In that case no PSP L1 directory is created?
That raises a bigger question for me:
What is the difference between `combo_new_rab` and `recovery_ab`? Can you point me to a place in the spec that talks about it?