30 Sep
2020
30 Sep
'20
10:52 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45558 )
Change subject: mb/getac/p470/acpi: Convert 'superio.asl' to ASL 2.0 syntax ......................................................................
Patch Set 1:
(1 comment)
next time, this would be much easier to review if it were split up. looks good other than the extra line I found
https://review.coreboot.org/c/coreboot/+/45558/1/src/mainboard/getac/p470/ac... File src/mainboard/getac/p470/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/45558/1/src/mainboard/getac/p470/ac... PS1, Line 121: ShiftLeft(Local0, 0x02, Local0) you left this line in
--
To view, visit https://review.coreboot.org/c/coreboot/+/45558
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I620b9d3befd0a1a1440c6cc8908214b7b7a233bc
Gerrit-Change-Number: 45558
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 30 Sep 2020 19:52:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment