[coreboot-gerrit] Change in coreboot[master]: drivers/intel/gma: Rework brightness level includes

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48862 )

Change subject: drivers/intel/gma: Rework brightness level includes
......................................................................

Patch Set 1:

I'm somehow missing, what the improvement here really is besides that the custom brightness table version is more explicit and more flexible.

So, for the case with default brightness nothing changes, right?

Example:

#include <drivers/intel/gma/acpi/gma.asl>
#include <drivers/intel/gma/acpi/default_brightness_levels.asl>

When using a custom brightness table, one needs to include three files now instead of one:

Example:

#include <drivers/intel/gma/acpi/gma.asl>

Scope (GFX0)
{
  Name (BRIG, Package()
  {
     ...
  },
},

Becomes this:

#include <drivers/intel/gma/acpi/gma.asl>

Scope (GFX0)
{
  #include <drivers/intel/gma/acpi/configure_brightness_levels.asl>
  #include <drivers/intel/gma/acpi/common.asl>

Name (BRIG, Package()
  {
     ...
  },
}