[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common: Skip SoC GT programming based on CONFIG_SKIP_GRAPHI...

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33189 )

Change subject: soc/intel/common: Skip SoC GT programming based on CONFIG_SKIP_GRAPHICS_ENABLING
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/33189/1/src/soc/intel/common/block/graphics/... 
File src/soc/intel/common/block/graphics/Kconfig:

https://review.coreboot.org/#/c/33189/1/src/soc/intel/common/block/graphics/... 
PS1, Line 6: config SKIP_GRAPHICS_ENABLING
How would this differ from NO_GFX_INIT (src/device/Kconfig)?

https://review.coreboot.org/#/c/33189/1/src/soc/intel/icelake/graphics.c 
File src/soc/intel/icelake/graphics.c:

https://review.coreboot.org/#/c/33189/1/src/soc/intel/icelake/graphics.c@48 
PS1, Line 48: DDI_A_4_LANES
This is a setting that usually is expected to be done by the firmware,
why do you want to skip it?