Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34778 )
Change subject: soc/mediatek: Change DSI init commands to take flexible length array
......................................................................
Patch Set 19:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34778/13/src/mainboard/google/kukui...
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34778/13/src/mainboard/google/kukui...
PS13, Line 132: (const struct lcm_init_command *)panel->init) < 0) {
Just change the function to take a (u8 *) instead, you need casts in there anyway.
Done
https://review.coreboot.org/c/coreboot/+/34778/13/src/mainboard/google/kukui...
File src/mainboard/google/kukui/panel.h:
https://review.coreboot.org/c/coreboot/+/34778/13/src/mainboard/google/kukui...
PS13, Line 27: char
u8
Done
https://review.coreboot.org/c/coreboot/+/34778/13/src/mainboard/google/kukui...
PS13, Line 36: __VA_ARGS__
Woah... this is one of those "just crazy enough it could work" things. […]
But Jenkins is not happy about it and I'm not sure how to solve that...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34778
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I359dde8e6f2e1c0983f4677193bb47a7ae497ca6
Gerrit-Change-Number: 34778
Gerrit-PatchSet: 19
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Aug 2019 03:54:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment