Michael Büchler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45317 )
Change subject: mb/asrock: Add ASRock H77 Pro4-M mainboard ......................................................................
Patch Set 3:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@14 PS2, Line 14: Pro4
Pro3
Done
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@19 PS2, Line 19: - PS/2 mouse or keyboard
Both work, only one port?
Should be more clear now. Both mouse and keyboard are tested and work.
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@25 PS2, Line 25: - All eight SATA ports
6 on the PCH and 2 on ASM1061 PCIe-to-SATA bridge
Done
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@38 PS2, Line 38: Internal flashing with flashrom-1.2 (no write permission on BIOS : region).
Even with coreboot?
Yes. I didn't take notes on everything or investigate properly what I'm doing but when I modified these values in the FD at 0x62, 0x66, 0x6a to 0xffff (all of them) I was able to write (flashrom-1.2, booted from coreboot). At some address it failed, though.
https://review.coreboot.org/c/coreboot/+/45317/2//COMMIT_MSG@40 PS2, Line 40: - The ME on my board. While measuring on the Super I/O pins during S3 : suspend I probably shorted something. Since then the ME has trouble : coming up and the vendor BIOS doesn't work anymore. coreboot works. : I'm now testing with `me_cleaner -S` applied.
Tried fresh ME firmware? You can use the Instant Flash image from https://www.asrock. […]
Yes, I tried those (2.00 and Beta 2.10). After the measurement incident I put the original SPI chip with the untouched vendor BIOS back in and it didn't work. I had dropped the chip just before so first I thought some bits had fallen out, but no, that wasn't it :) Another PSU won't help either.
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... File src/mainboard/asrock/h77pro4-m/Kconfig:
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... PS2, Line 11: INTEL_INT15
Drop this since no INT15 handler is installed.
Done
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... PS2, Line 29: default "src/mainboard/$(MAINBOARDDIR)/data.vbt"
Add an empty line between Kconfig options
Done
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... File src/mainboard/asrock/h77pro4-m/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... PS2, Line 1: /* dummy */
just keep it empty
Done
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... File src/mainboard/asrock/h77pro4-m/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/45317/2/src/mainboard/asrock/h77pro... PS2, Line 13: HDMI3,
nit: Which is HDMI, and which is DVI? Feel free to add comments
Easy, I took notes on it anyway