Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45747 )
Change subject: soc/intel/tigerlake: Replace soc_get_pmc_mux_device with device pointers ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45747/7/src/ec/google/chromeec/chip... File src/ec/google/chromeec/chip.h:
https://review.coreboot.org/c/coreboot/+/45747/7/src/ec/google/chromeec/chip... PS7, Line 6: #include <stddef.h>
#include <device/device. […]
Done
https://review.coreboot.org/c/coreboot/+/45747/8/src/ec/google/chromeec/ec_a... File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/45747/8/src/ec/google/chromeec/ec_a... PS8, Line 138: for (i = 0; i < num_ports; ++i) {
Should there be a check here: […]
I'm not sure if we should bail or attempt to write as much as we know about, I'm inclined to think we should write as much as we can; downstream code will deal with the NULL, and this information is all included in _DSD so the kernel should be able to deal with not finding a node.