Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44397 )
Change subject: mb/google/dedede: Replace static Camera ACPI by driver for WDoo
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede...
PS9, Line 229: "GPP_D13" #power_enable_2p8
: register "gpio_panel.gpio[1].gpio_num" = "GPP_D14"
Yes, it should work exactly that way. […]
@Matt,
Every resource operation (GPIO/clock) is protected with a reference count variable, irrespective whether it is shared or not. The resource is actually disabled only if the reference count reaches zero.
Earlier we were following the approach what @Tim mentioned but it was causing issues and complications in handling scenarios where the resource is not properly marked as shared in the devicetree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44397
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e875d297c04f35d4e980ff33d9a3767d2910ac
Gerrit-Change-Number: 44397
Gerrit-PatchSet: 9
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Matt Delco
delco@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 03 Sep 2020 03:52:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt Delco
delco@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment