Attention is currently required from: Nico Huber, Angel Pons.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39374 )
Change subject: soc/{apl,glk}: Allow to select the primary graphics device
......................................................................
Patch Set 31:
(1 comment)
File src/soc/intel/apollolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/39374/comment/0ded6962_624a5288
PS30, Line 239: mupd->FspmConfig.PrimaryVideoAdaptor =
: is_devfn_enabled(SA_DEVFN_IGD) && CONFIG(ONBOARD_VGA_IS_PRIMARY) ?
: GPU_PRIMARY_IGD : GPU_PRIMARY_PCI;
nit: I'd do the Kconfig check first so that the compiler can optimise things out when it's false. […]
Thx
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcd117217cf412ee0722aff52db4b3c8ec2a226c
Gerrit-Change-Number: 39374
Gerrit-PatchSet: 31
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 22 Jul 2021 11:57:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment