SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38826 )
Change subject: mb/google/hatch: Create nightfury variant
......................................................................
Patch Set 43:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38826/43/src/mainboard/google/hatch...
File src/mainboard/google/hatch/variants/nightfury/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38826/43/src/mainboard/google/hatch...
PS43, Line 29: gpio_output(GPP_C11, 1);
: mdelay(1);
: gpio_output(GPP_A12, 1);
This is specific to the FPMCU. […]
1. This code can be removed.
2. As I checked unused GPIO pads in current schematics have been configured as NC now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38826
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If08692f4a2d216c57499098cc0e35abd708d99d4
Gerrit-Change-Number: 38826
Gerrit-PatchSet: 43
Gerrit-Owner: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 10 Mar 2020 02:39:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment