Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48925 )
Change subject: device/pnp,util/sconfig: introduce and use `REG8` resource type ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48925/6/src/device/pnp_device.c File src/device/pnp_device.c:
https://review.coreboot.org/c/coreboot/+/48925/6/src/device/pnp_device.c@105 PS6, Line 105: 0x30
0x30 is not a generic register and should never be mentioned in a […]
well, there is PNP_EN, which also is no irq, but was handled as such, see line 280
https://review.coreboot.org/c/coreboot/+/48925/6/src/device/pnp_device.c@105 PS6, Line 105: 0xf0-0xfe
There is more.
yes, thus 'e.g'
https://review.coreboot.org/c/coreboot/+/48925/6/src/device/pnp_device.c@137 PS6, Line 137: } else if (resource->flags & IORESOURCE_DRQ) { : pnp_set_drq(dev, resource->index, resource->base); : } else if (resource->flags & IORESOURCE_IRQ) { : pnp_set_irq(dev, resource->index, resource->base); : } else if (resource->flags & IORESOURCE_REG8) { : pnp_set_reg8(dev, resource->index, resource->base);
Looks all the same to me. Also, for all three, coreboot has no rules for […]
wdym with "coreboot has no rules"?