build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32188 )
Change subject: WIP: Power resource stub ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/32188/1/src/drivers/generic/power_resource/p... File src/drivers/generic/power_resource/power_resource.c:
https://review.coreboot.org/#/c/32188/1/src/drivers/generic/power_resource/p... PS1, Line 31: printk(BIOS_WARNING, "@@ in power_resource_dev_enable\n"); Prefer using '"%s...", __func__' to using 'power_resource_dev_enable', this function's name, in a string
https://review.coreboot.org/#/c/32188/1/src/drivers/i2c/generic/generic.c File src/drivers/i2c/generic/generic.c:
https://review.coreboot.org/#/c/32188/1/src/drivers/i2c/generic/generic.c@30 PS1, Line 30: static bool i2c_generic_add_gpios_to_crs(struct drivers_generic_power_resource_config *pr_config, line over 80 characters
https://review.coreboot.org/#/c/32188/1/src/drivers/i2c/generic/generic.c@12... PS1, Line 127: if (pr_config && i2c_generic_add_gpios_to_crs(pr_config, config) == true) { line over 80 characters
https://review.coreboot.org/#/c/32188/1/src/include/device/device.h File src/include/device/device.h:
https://review.coreboot.org/#/c/32188/1/src/include/device/device.h@129 PS1, Line 129: unsigned int probed : 1; /* set if device's presence should be probed */ line over 80 characters