[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configu...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33129 )

Change subject: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configuration
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33129/11/src/soc/intel/common/pch/t... 
File src/soc/intel/common/pch/thermal/thermal.c:

https://review.coreboot.org/c/coreboot/+/33129/11/src/soc/intel/common/pch/t... 
PS11, Line 90: printk(BIOS_ERR, "ERROR: PCH thermalbar not found!\n");
             : 		return;
> A proper solution would be valid devicetree. […]

IMO, in bios world tempbar is not the hack. Why BIOS should do another PCI device enumeration when it doesn't have any business with it. For sure BIOS is not going to use this thermal device during POST. Its just to configure a  device register(THERMAL_SENSOR_POWER_MANAGEMENT) and leave that device.