Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31968 )
Change subject: mediatek/mt8183: Fix RTC initialization flow ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31968/3/src/soc/mediatek/mt8173/include/soc/... File src/soc/mediatek/mt8173/include/soc/rtc.h:
https://review.coreboot.org/#/c/31968/3/src/soc/mediatek/mt8173/include/soc/... PS3, Line 81: 0 Is this intended? If so, please explain in the patch description.
https://review.coreboot.org/#/c/31968/3/src/soc/mediatek/mt8183/include/soc/... File src/soc/mediatek/mt8183/include/soc/rtc.h:
https://review.coreboot.org/#/c/31968/3/src/soc/mediatek/mt8183/include/soc/... PS3, Line 80: 0 This one too
https://review.coreboot.org/#/c/31968/3/src/soc/mediatek/mt8183/rtc.c File src/soc/mediatek/mt8183/rtc.c:
https://review.coreboot.org/#/c/31968/3/src/soc/mediatek/mt8183/rtc.c@177 PS3, Line 177: if (!rtc_write_trigger()) : return false; : : return true; return rtc_write_trigger();