Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34381 )
Change subject: src/security/tpm/tss: Add support for PTT ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34381/12/src/security/tpm/tss/tcg-2... File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/34381/12/src/security/tpm/tss/tcg-2... PS12, Line 195: if (CONFIG(HAVE_INTEL_PTT)) { I'm confused how this works and why this has to be here. Where is the code that implements tis_init() and tis_open() for this TPM? I don't see it anywhere in this patch train.
(If this is one of those weird Intel things where the hardware emulates a legacy interface and you're using e.g. src/drivers/pc80/tpm to access this, this config option and code should be in there, not here. It's an implementation detail of the TPM implementation driver, not the protocol stack.)