Attention is currently required from: Felix Held, Patrick Rudolph.
Maximilian Brune has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86386?usp=email )
Change subject: device/pci_rom: Support non VGA iGPUs ......................................................................
Patch Set 4: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86386/comment/3a92e88a_3a15ab93?usp... : PS4, Line 9: any more anymore
https://review.coreboot.org/c/coreboot/+/86386/comment/49348185_1ef9f9ad?usp... : PS4, Line 10: any more anymore
File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/86386/comment/b3b7b75a_d72b024a?usp... : PS4, Line 210: ((uintptr_t)rom < MiB) ? "initialized " : "", rom);
The original code assumed that VGA_ROM_RUN was being used and the ROM in the C-segment had been run. […]
Can we just remove the "initialized" stuff from the printing message? I don't think we should assume that the rom has been run/initialized just because it was already loaded into lower memory.