Hannah Williams has posted comments on this change. ( https://review.coreboot.org/28060 )
Change subject: intel/common/block: Fix issues found by klockwork ......................................................................
Patch Set 2:
Patch Set 1:
(1 comment)
Martin, What tool are you using for this code scan - we're not getting these "soc issues" flagged, using Klocwork Static Code Analysis tool? We are getting different "warnings" in chip.c and gspi.c files.
These are generated using clang's scan-build tool: https://clang-analyzer.llvm.org/scan-build.html
We also run coverity's stataic analysis on a bi-weekly basis. That output is here: https://scan.coverity.com/projects/coreboot?tab=overview That finds still different issues in soc/intel.
I have a feeling that since static.c gets deleted from the emerge build, so KW does not see the dev_root structure and hence we have been getting errors reported for possible NULL access for dev = dev_find_path