Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40286 )
Change subject: drivers/ipmi: Implement the function for logging system event into BMC
......................................................................
Patch Set 4:
(1 comment)
thanks !
https://review.coreboot.org/c/coreboot/+/40286/4/src/drivers/ipmi/ipmi_ops.c
File src/drivers/ipmi/ipmi_ops.c:
https://review.coreboot.org/c/coreboot/+/40286/4/src/drivers/ipmi/ipmi_ops.c...
PS4, Line 126: unsigned char data[16];
would it be possible to define type for this data?
this way we can avoid all the memcpy and hardcoded lengths, and just can initialize data structure in one go, i.e
stuct blah data = { .a = x, .b = y, c = z } and so on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38f3acb958d12c196d33d34fd5cfa0b784f403b7
Gerrit-Change-Number: 40286
Gerrit-PatchSet: 4
Gerrit-Owner: Morgan Jang
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Apr 2020 16:53:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment