Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45942 )
Change subject: vc/amd/fsp: Update the svc call header for the Mod Exp SVC ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45942/1/src/vendorcode/amd/fsp/pica... File src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h:
https://review.coreboot.org/c/coreboot/+/45942/1/src/vendorcode/amd/fsp/pica... PS1, Line 406: unsigned int svc_modexp(MOD_EXP_PARAMS *mod_exp_param); Wouldn't it be better to use "uint32_t" instead of "unsigned int" for return type to match other svc APIs?