Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42079 )
Change subject: soc/intel/tigerlake: Add code for early tcss
......................................................................
Patch Set 27:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42079/27/src/soc/intel/tigerlake/fs...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42079/27/src/soc/intel/tigerlake/fs...
PS27, Line 390: if (CONFIG(EARLY_TCSS) && (vboot_recovery_mode_enabled() ||
: vboot_developer_mode_enabled()))
: mainboard_early_tcss_enable();
Understood. Apologize for the long review cycle here. […]
Sure I will update the commit message and Kconfig message
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42079
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58e66f21210d565fb8145d140d2fc7febecdd21a
Gerrit-Change-Number: 42079
Gerrit-PatchSet: 27
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-Comment-Date: Thu, 12 Nov 2020 18:37:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment