Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44816 )
Change subject: util/ifdtool: Identify between ICH and PCH Revision
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44816/1/util/ifdtool/ifdtool.c
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44816/1/util/ifdtool/ifdtool.c@767
PS1, Line 767: if (is_platform_with_pch())
: printf("PCH Revision: %s\n", ich_chipset_names[chipset]);
: else
: printf("ICH Revision: %s\n", ich_chipset_names[chipset]);
nit: something like […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4
Gerrit-Change-Number: 44816
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 27 Aug 2020 07:52:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment