build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48525 )
Change subject: amdfwtool: Add support of cezanne and renoir ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48525/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/48525/1/util/amdfwtool/amdfwtool.c@... PS1, Line 473: ((psp_directory_header *) ptr) -> additional_info = ctx->current; spaces prohibited around that '->' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/48525/1/util/amdfwtool/amdfwtool.c@... PS1, Line 506: assert (!(table_size % TABLE_ALIGNMENT)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/48525/1/util/amdfwtool/amdfwtool.c@... PS1, Line 807: ((bios_directory_hdr *) ptr) -> additional_info = ctx->current; spaces prohibited around that '->' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/48525/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1666: switch (soc_id) { switch and case should be at the same indent