Attention is currently required from: Felix Singer, Michał Żygowski, Piotr Król.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59888 )
Change subject: mainboard: Drop `SataMode` setting from Skylake devicetrees
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Patchset:
PS4:
This should be an user-configurable setting, right, but not sure if it should be done with CMOS or K […]
Why not both? It's very easy to do with the new option API, CB:56256 is an example.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59888
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9be5eca93cac65afc4cc30ceb64d9a5b7e5cd514
Gerrit-Change-Number: 59888
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Sat, 11 Dec 2021 10:18:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment