13 Oct
2020
13 Oct
'20
8:55 a.m.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46219 )
Change subject: mb/facebook/fbg1701: Add VBOOT support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46219/2/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/c/coreboot/+/46219/2/src/mainboard/facebook/fbg1... PS2, Line 103: depends on VBOOT
I'd avoid the `depends on` clause for this, so that a fmap can be used even when VBOOT is not enable […]
I will update 'depends on' to !USE_VENDORCODE_ELTAN.
--
To view, visit https://review.coreboot.org/c/coreboot/+/46219
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I641bca58c0f7c81d5742235c8b2c184d13c00c55
Gerrit-Change-Number: 46219
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 13 Oct 2020 06:55:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment