[coreboot-gerrit] Change in ...coreboot[master]: soc/sifive/fu540: add code to initialize flash

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30466 )

Change subject: soc/sifive/fu540: add code to initialize flash
......................................................................

Patch Set 22:

(3 comments)

https://review.coreboot.org/#/c/30466/22/src/soc/sifive/fu540/spi_flash.c 
File src/soc/sifive/fu540/spi_flash.c:

https://review.coreboot.org/#/c/30466/22/src/soc/sifive/fu540/spi_flash.c@29 
PS22, Line 29: 	// Max desired SPI clock is 10MHz
why? is that a soc limit?

https://review.coreboot.org/#/c/30466/22/src/soc/sifive/fu540/spi_flash.c@40 
PS22, Line 40: int _initialize_spi_flash_mmap(
what does this function do?

https://review.coreboot.org/#/c/30466/22/src/soc/sifive/fu540/spi_flash.c@63 
PS22, Line 63: int initialize_spi_flash_mmap_single(
where's the difference to initialize_spi_flash_mmap_quad ?