Attention is currently required from: Diana Zigterman, Jason Glenesk, Nikolai Vyssotski.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55434 )
Change subject: mb/google/guybrush: Enable STT in device tree
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55434/comment/fa0c82c3_e9797afe
PS3, Line 66: register "stt_skin_temp_apu" = "0x2D00"
Thanks Paul. […]
Agreed. It’d be great, if you could add it to your internal tracker somewhere.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37b5da1b56586ef75ad17f6766cd00ddac87aa5a
Gerrit-Change-Number: 55434
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Diana Zigterman
dzigterman@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Diana Zigterman
dzigterman@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Comment-Date: Tue, 17 Aug 2021 07:38:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-MessageType: comment