Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32662 )
Change subject: soc/amd/stoneyrige: Add ALink-AHB Bridge to iomap.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32662/1/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/iomap.h:
https://review.coreboot.org/#/c/32662/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 31: #define I2C_BASE_ADDRESS 0xfedc2000 : #define I2C_DEVICE_SIZE 0x00001000 : #define I2C_DEVICE_COUNT 4 : : I agree with alignment, but it does not belong to the commit (not mentioned on commit message). I do believe it should be a separate patch, I don't care with order (could be the very last patch, as a clean up).