Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38452 )
Change subject: soc/intel/tigerlake: Add pinmux support
......................................................................
Patch Set 10: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38452/9/src/soc/intel/tigerlake/inc...
File src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h:
https://review.coreboot.org/c/coreboot/+/38452/9/src/soc/intel/tigerlake/inc...
PS9, Line 297: * mux for these pins.
Current TGL FSP configures all native function based on IP enable UPD and there is no way to skip FS […]
I ran a quick test last week where I skipped setting all the PinMux UPDs and I did not run into any abort (This test was done with FSP debug disabled). Can you please verify this at your end.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38452
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51deba87fcd1cde248e0f73757acf97682879090
Gerrit-Change-Number: 38452
Gerrit-PatchSet: 10
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Mon, 27 Jan 2020 05:46:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-MessageType: comment