build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32513 )
Change subject: soc/intel/cannonlake: Clean up cannonlake_memcfg_init
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32513/1/src/soc/intel/cannonlake/cnl_memcfg_...
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
https://review.coreboot.org/#/c/32513/1/src/soc/intel/cannonlake/cnl_memcfg_...
PS1, Line 108: spd_spec.spd_smbus_address[i];
Avoid multiple line dereference - prefer 'cnl_cfg->spd.spd_spec.spd_smbus_address[i]'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32513
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I686a85996858204c20fd05ef24787a0487817c34
Gerrit-Change-Number: 32513
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Apr 2019 17:54:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment