Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Subrata Banik.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81115?usp=email )
Change subject: soc/intel/alderlake: Add Raptor Lake System Agent Device IDs ......................................................................
Patch Set 1: Code-Review+1
(6 comments)
File src/soc/intel/alderlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/81115/comment/c1b47a95_16552346 : PS1, Line 87: { PCI_DID_INTEL_RPL_P_ID_1, "Raptorlake-H/H Refresh (6+8)" }, There's two platforms with ID 0xA706:
- H 6P+8E - P 6P+8E
Looks like the name should be `Raptorlake-H/P (6+8)`
https://review.coreboot.org/c/coreboot/+/81115/comment/990224ff_4ab8b3cc : PS1, Line 88: { PCI_DID_INTEL_RPL_P_ID_2, "Raptorlake-H/H Refresh (4+8)" }, There's two platforms with ID 0xA707:
- H 4P+8E - P 4P+8E
Looks like the name should be `Raptorlake-H/P (4+8)`
File src/soc/intel/alderlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/81115/comment/2518de62_d1c9dc09 : PS1, Line 131: { PCI_DID_INTEL_RPL_P_ID_1, 45, VR_CFG_ALL_DOMAINS_LOADLINE(2.3, 3.2) }, For another patch: I think this table is missing an entry for `PCI_DID_INTEL_RPL_P_ID_1` RPL-P (28W), it only has the entry for `PCI_DID_INTEL_RPL_P_ID_1` RPL-H (45W).
https://review.coreboot.org/c/coreboot/+/81115/comment/b2d5ed85_f8009782 : PS1, Line 195: { PCI_DID_INTEL_RPL_P_ID_1, 45, VR_CFG_ALL_DOMAINS_ICC(160, 55) }, Same as above
https://review.coreboot.org/c/coreboot/+/81115/comment/01818dcd_81aac476 : PS1, Line 259: { PCI_DID_INTEL_RPL_P_ID_1, 45, VR_CFG_ALL_DOMAINS_TDC(28000, 28000) }, Same as above
https://review.coreboot.org/c/coreboot/+/81115/comment/a7edc903_3ccb6752 : PS1, Line 323: { PCI_DID_INTEL_RPL_P_ID_1, 45, VR_CFG_ALL_DOMAINS_TDC_CURRENT(86, 86) }, Same as above